Skip to content

odin Fixed memory leak in connect_memory_and_alias function in netlist_cre… #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2019
Merged

odin Fixed memory leak in connect_memory_and_alias function in netlist_cre… #662

merged 1 commit into from
Jun 20, 2019

Conversation

j-b-1-7
Copy link
Contributor

@j-b-1-7 j-b-1-7 commented Jun 20, 2019

…ate_from_ast.cpp

Description

freed the allocated string full_name before the pointer was updated so that it would not be lost.

Types of changes

  • [x ] Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • [x ] All new and existing tests passed

@probot-autolabeler probot-autolabeler bot added lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item labels Jun 20, 2019
jeanlego
jeanlego reviewed Jun 20, 2019
View reviewed changes
Copy link
Contributor

@jeanlego jeanlego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good otherwise! @ademmings?

ODIN_II/SRC/netlist_create_from_ast.cpp
@@ -2311,6 +2312,8 @@ void connect_memory_and_alias(ast_node_t* hb_instance, char *instance_name_prefi
hb_instance->children[1]->children[0]->types.identifier,
hb_connect_list->children[i]->children[0]->types.identifier, -1);
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid white space changes in your commits

@ademmings
Copy link
Contributor

agreed!

@j-b-1-7 j-b-1-7 changed the title WIP: odin Fixed memory leak in connect_memory_and_alias function in netlist_cre… odin Fixed memory leak in connect_memory_and_alias function in netlist_cre… Jun 20, 2019
@jeanlego jeanlego merged commit d2a1ef4 into verilog-to-routing:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanlego jeanlego jeanlego left review comments

Assignees
No one assigned
Labels
lang-cpp C/C++ code Odin Odin II Logic Synthesis Tool: Unsorted item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j-b-1-7 @ademmings @jeanlego